-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: modify vbk failed when all backups are complete or failed #5735
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test-pull-e2e-kind-br |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5735 +/- ##
===========================================
- Coverage 61.47% 34.78% -26.69%
===========================================
Files 235 219 -16
Lines 30653 30626 -27
===========================================
- Hits 18843 10653 -8190
- Misses 9920 18581 +8661
+ Partials 1890 1392 -498
|
/run-pull-e2e-kind |
@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created. In response to adding label named type/cherry-pick-for-release-1.5. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Closes #5725
What is changed and how does it work?
only set volume backup is done (failed or complete) after all data planes are done at waiting snapshot creation time whose during is long.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.