Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: modify vbk failed when all backups are complete or failed #5735

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

WangLe1321
Copy link
Contributor

@WangLe1321 WangLe1321 commented Sep 13, 2024

What problem does this PR solve?

Closes #5725

What is changed and how does it work?

only set volume backup is done (failed or complete) after all data planes are done at waiting snapshot creation time whose during is long.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 9, 2024
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/test-pull-e2e-kind-br

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.78%. Comparing base (9ef26f8) to head (a9e3867).
Report is 26 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9ef26f8) and HEAD (a9e3867). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9ef26f8) HEAD (a9e3867)
unittest 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5735       +/-   ##
===========================================
- Coverage   61.47%   34.78%   -26.69%     
===========================================
  Files         235      219       -16     
  Lines       30653    30626       -27     
===========================================
- Hits        18843    10653     -8190     
- Misses       9920    18581     +8661     
+ Partials     1890     1392      -498     
Flag Coverage Δ
e2e 34.78% <ø> (?)
unittest ?

@BornChanger
Copy link
Contributor

/run-pull-e2e-kind

Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

@BornChanger: You cannot manually add or delete the cherry pick branch category labels. It will be added automatically by bot when the PR is created.

In response to adding label named type/cherry-pick-for-release-1.5.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Oct 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-09 07:39:38.379792891 +0000 UTC m=+1031733.800005888: ☑️ agreed by BornChanger.
  • 2024-10-09 10:16:22.233479006 +0000 UTC m=+1041137.653692010: ✖️🔁 reset by csuzhangxc.

Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

New changes are detected. LGTM label has been removed.

@csuzhangxc csuzhangxc merged commit 4af46b7 into pingcap:master Oct 9, 2024
5 checks passed
@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@csuzhangxc
Copy link
Member

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5761.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5762.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebs br: don't mark volumebackup failed too early
5 participants