Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add operator upgrade case #579

Merged
merged 12 commits into from
Jun 21, 2019
Merged

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

  • add operator upgrade case

What is changed and how it works?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

@weekface weekface marked this pull request as ready for review June 21, 2019 02:25
@weekface
Copy link
Contributor Author

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

@cofyc PTAL

WebhookURL string
Channel string
WebhookURL string
SuccessCount int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SuccessCount is not used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit a1815fe into pingcap:master Jun 21, 2019
@weekface weekface deleted the upgrade-operator branch June 21, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants