-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add operator upgrade case #579
Conversation
34a298f
to
863aad2
Compare
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cofyc PTAL |
WebhookURL string | ||
Channel string | ||
WebhookURL string | ||
SuccessCount int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SuccessCount
is not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used at these postions:
https://github.com/pingcap/tidb-operator/pull/579/files#diff-2ef72aa70c90226cd8aac8a436f9bff9R150
https://github.com/pingcap/tidb-operator/pull/579/files#diff-8f8eafaeec65b7926966885b1c103ca8R58
https://github.com/pingcap/tidb-operator/pull/579/files#diff-8f8eafaeec65b7926966885b1c103ca8R300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: