Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure go modules files are always tidy #588

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Make sure go modules files are always tidy #588

merged 1 commit into from
Jun 17, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jun 17, 2019

What problem does this PR solve?

  • Make sure unused dependencies are removed
  • Make sure new dependencies are added into go.mod/go.sum
    • e.g. packages can be built successfully when dependencies are in GOPATH only

What is changed and how it works?

copied from PD project

https://github.com/pingcap/pd/blob/ead664582ffb0d804115eb2db1ac753aa00a749c/Makefile#L101-L104

Check List

Tests

  • Unit test

Does this PR introduce a user-facing change?:

NONE

@cofyc
Copy link
Contributor Author

cofyc commented Jun 17, 2019

/run-e2e-tests

@cofyc cofyc changed the title Make sure go modules files are always tidy and up to date Make sure go modules files are always tidy Jun 17, 2019
@cofyc cofyc requested review from aylei, tennix, weekface and xiaojingchen and removed request for tennix June 17, 2019 05:33
aylei
aylei approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@cofyc cofyc merged commit fe6bef7 into pingcap:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@weekface weekface weekface approved these changes

@tennix tennix Awaiting requested review from tennix

@xiaojingchen xiaojingchen Awaiting requested review from xiaojingchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cofyc @weekface @aylei