build without debugger symbols #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the binaries significantly smaller before: 30M images/tidb-operator/bin/tidb-admission-controller 47M images/tidb-operator/bin/tidb-controller-manager 42M images/tidb-operator/bin/tidb-discovery 32M images/tidb-operator/bin/tidb-scheduler after: 30M images/tidb-operator/bin/tidb-admission-controller 36M images/tidb-operator/bin/tidb-controller-manager 32M images/tidb-operator/bin/tidb-discovery 24M images/tidb-operator/bin/tidb-scheduler
xiaojingchen
approved these changes
Jun 20, 2019
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
2 tasks
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the binaries significantly smaller
before:
30M images/tidb-operator/bin/tidb-admission-controller
47M images/tidb-operator/bin/tidb-controller-manager
42M images/tidb-operator/bin/tidb-discovery
32M images/tidb-operator/bin/tidb-scheduler
after:
30M images/tidb-operator/bin/tidb-admission-controller
36M images/tidb-operator/bin/tidb-controller-manager
32M images/tidb-operator/bin/tidb-discovery
24M images/tidb-operator/bin/tidb-scheduler
Note that stack traces still work, this information is just for the debugger. Set DEBUGGER=1 to build for debuggers. Eventually we may need to distribute both of these.
This issue came up when I was adding a new binary and it was initially 40M in size! After some changes I made, even after adding that binary the total binary size of all binaries will be smaller
Testing
I ran these binaries on GKE. I did see proper stack information from a panic.