Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tidb user of scheduled backup script #594

Merged
merged 1 commit into from
Jun 19, 2019
Merged

fix tidb user of scheduled backup script #594

merged 1 commit into from
Jun 19, 2019

Conversation

LinuxGit
Copy link
Contributor

What problem does this PR solve?

fix tidb user of scheduled backup script

What is changed and how it works?

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

fix tidb user of scheduled backup script

@LinuxGit
Copy link
Contributor Author

/run-e2e-tests

DanielZhangQD
DanielZhangQD approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxGit LinuxGit merged commit 6ee2ba0 into pingcap:master Jun 19, 2019
@LinuxGit LinuxGit deleted the Louis/fix-backup-chart branch June 19, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinuxGit @xiaojingchen @DanielZhangQD