Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notes of tidb-backup chart #595

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Conversation

LinuxGit
Copy link
Contributor

@LinuxGit LinuxGit commented Jun 20, 2019

What problem does this PR solve?

What is changed and how it works?

fix notes of tidb-backup chart

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@LinuxGit LinuxGit changed the title fix notes of tidb-backup chart [DNM]fix notes of tidb-backup chart Jun 20, 2019
@LinuxGit LinuxGit changed the title [DNM]fix notes of tidb-backup chart fix notes of tidb-backup chart Jun 20, 2019
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pingcap/tidb-operator/pull/595/files#diff-20cc15a5c5f2a4329b4b6719ee74d0d6R10

should be modified with:

   watch kubectl get po --namespace {{ .Release.Namespace }}  -l app.kubernetes.io/component={{ .Values.mode }}

@weekface
Copy link
Contributor

/run-e2e-tests

@LinuxGit
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor

/run-e2e-tests

@gregwebs gregwebs merged commit b6da072 into pingcap:master Jun 28, 2019
@LinuxGit LinuxGit deleted the Louis/fix-chart branch March 5, 2020 05:50
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants