-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kube-scheduler image instead of hyperkube #596
Conversation
/run-e2e-tests |
I remember that the registry has changed to |
Updated to use |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
@cofyc This actually has user-facing change, when upgrading, a new image needs to be pulled. This has an impact if user's deployment is in airgap environment. |
@@ -54,6 +54,6 @@ scheduler: | |||
requests: | |||
cpu: 80m | |||
memory: 50Mi | |||
kubeSchedulerImageName: gcr.io/google-containers/hyperkube | |||
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler | |
# This image is much smaller then gcr.io/google-containers/hyperkube | |
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler |
@tennix I think it is reasonable to expect users to inspect all the changes to the values file on upgrade if we haven't re-structured them. In an airgap environment wouldn't you pull the image and push it with a new tag to your own repository anyways? |
@gregwebs The user-facing change is for our release note. In an airgap environment, users may think only newer tidb-operator image is required when upgrading tidb-operator. So I think we should have a release note for this change. |
I'm going to add a release note for airgap users. |
Release note has been updated. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
What problem does this PR solve?
Use scheduler image instead of hyperkube which is unnecessary and very large.
Does this PR introduce a user-facing change?: