Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kube-scheduler image instead of hyperkube #596

Merged
merged 5 commits into from
Jun 27, 2019
Merged

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jun 20, 2019

What problem does this PR solve?

Use scheduler image instead of hyperkube which is unnecessary and very large.

# docker images | grep v1.12.2
gcr.io/google-containers/hyperkube                               v1.12.2                      3e4497624dd0        7 months ago        635MB
gcr.io/google_containers/kube-scheduler                          v1.12.2                      d6d57c76136c        7 months ago        58.3MB

Does this PR introduce a user-facing change?:

Scheduler image is updated to use "k8s.gcr.io/kube-scheduler" which is much smaller than "gcr.io/google-containers/hyperkube". You must pre-pull the new scheduler image into your airgap environment before upgrading.

@cofyc cofyc requested review from weekface, tennix and aylei June 20, 2019 03:22
@cofyc
Copy link
Contributor Author

cofyc commented Jun 20, 2019

/run-e2e-tests

@tennix
Copy link
Member

tennix commented Jun 20, 2019

I remember that the registry has changed to k8s.gcr.io.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 20, 2019

Updated to use k8s.gcr.io.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 20, 2019

/run-e2e-tests

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor Author

cofyc commented Jun 21, 2019

/run-e2e-tests

@weekface
Copy link
Contributor

/run-e2e-tests

1 similar comment
@cofyc
Copy link
Contributor Author

cofyc commented Jun 21, 2019

/run-e2e-tests

@tennix
Copy link
Member

tennix commented Jun 26, 2019

@cofyc This actually has user-facing change, when upgrading, a new image needs to be pulled. This has an impact if user's deployment is in airgap environment.

@@ -54,6 +54,6 @@ scheduler:
requests:
cpu: 80m
memory: 50Mi
kubeSchedulerImageName: gcr.io/google-containers/hyperkube
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler
# This image is much smaller then gcr.io/google-containers/hyperkube
kubeSchedulerImageName: k8s.gcr.io/kube-scheduler

@gregwebs
Copy link
Contributor

@tennix I think it is reasonable to expect users to inspect all the changes to the values file on upgrade if we haven't re-structured them.

In an airgap environment wouldn't you pull the image and push it with a new tag to your own repository anyways?

@tennix
Copy link
Member

tennix commented Jun 27, 2019

@gregwebs The user-facing change is for our release note. In an airgap environment, users may think only newer tidb-operator image is required when upgrading tidb-operator. So I think we should have a release note for this change.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 27, 2019

I'm going to add a release note for airgap users.

@cofyc
Copy link
Contributor Author

cofyc commented Jun 27, 2019

Release note has been updated. PTAL.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor Author

cofyc commented Jun 27, 2019

/run-e2e-tests

@tennix tennix changed the title Use scheduler image instead of hyperkube which is unnecessary and very large. Use kube-scheduler image instead of hyperkube Jun 27, 2019
@tennix tennix merged commit dbfd6e1 into pingcap:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants