Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the problem of unbound variable in the backup script #608

Merged
merged 3 commits into from
Jun 30, 2019
Merged

fix the problem of unbound variable in the backup script #608

merged 3 commits into from
Jun 30, 2019

Conversation

onlymellb
Copy link
Contributor

@onlymellb onlymellb commented Jun 26, 2019 •
edited
Loading

What problem does this PR solve?

When .Values.initialCommitTs is empty, the variable snapshot_args becomes undefined and causes the script to fail to exit.

What is changed and how it works?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

fix unbound variable in the backup script

@onlymellb onlymellb requested a review from weekface June 26, 2019 07:06
@weekface
Copy link
Contributor

/run-e2e-tests

@xiaojingchen
Copy link
Contributor

/run-e2e-tests

@gregwebs
Copy link
Contributor

/run-e2e-tests

@tennix tennix merged commit 25040b5 into pingcap:master Jun 30, 2019
@onlymellb onlymellb deleted the fix-unbound-variable branch July 2, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregwebs gregwebs gregwebs approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onlymellb @weekface @xiaojingchen @gregwebs @tennix