-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GKE local ssd provisioner for COS #612
Conversation
On COS, remount with UUID and set nobarrier. We do not combine multiple like on Ubuntu. Therefore this is recommended if your data size is < 375 GiB
We also have a [daemonset](../manifests/gke/local-ssd-provision.yaml) that | ||
* fixes any performance issues | ||
* remounts local SSD disks with a UUID for safety | ||
* On Ubuntu combines all local SSD disks into one large disk with lvm tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we let the user decide whether to combine the disks? In case users need to deploy multiple TiKV instances on one node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the cloud I don't think it makes sense to deploy multiple TiKV instances to one node. I am more concerned about a cluster that both runs tidb-operator and something else. But it is up to them to take these daemonsets and use them appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
The Ubuntu local SSD provisioner has a startup delay while provisioning packages. Make the local SSD provisioner work on COS.
What is changed and how does it work?
On COS, remount with UUID and set nobarrier.
We do not combine multiple disk like on Ubuntu.
Therefore this is recommended if your data size is < 375 GiB.
Note that by default COS does not set the nobarrier option. This script sets the nobarrier option when it remounts.
Check List
Tests
Code changes
Side effects
kubectl delete -n kube-system local-volume-provisioner
.Does this PR introduce a user-facing change?: