Simplify local SSD setup #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ubuntu image has the right packages pre-installed The same code can be ran on COS and Ubuntu. on COS, this adds the nobarrier option, which is already on Ubuntu remount with a UUID. lvm has noticeable overhead, so if there is just 1 disk, don't use it.
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
tennix
approved these changes
Jul 12, 2019
weekface
pushed a commit
that referenced
this pull request
Jul 29, 2019
The same code can be ran on COS and Ubuntu now. The Ubuntu image has the right packages pre-installed on COS, this adds the nobarrier option, which is already on Ubuntu remount with a UUID. lvm has noticeable overhead, so if there is just 1 disk, don't use it. (cherry picked from commit d0dc13a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ubuntu image has the right packages pre-installed
The same code can be ran on COS and Ubuntu.
on COS, this adds the nobarrier option, which is already on Ubuntu
remount with a UUID.
lvm has noticeable overhead, so if there is just 1 disk, don't use it.
Tests
This has been tested manually by creating several TiDB clusters with both COS and Ubuntu as the OS.
Code changes
manifests for GKE
Side effects
Breaking backward compatibility with the previous manifest.
Deploying this on a cluster that had a previous version of the manifests deployed could result in data loss. Upgrading this manifest must be done with great care.
Related changes
Does this PR introduce a user-facing change?:
-->