-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alibaba Cloud multiple tidb clusters management support #658
Conversation
Signed-off-by: Aylei <rayingecho@gmail.com>
- fix hardcode chart version - fix unreachable bastion - adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking - add version check - disable pd node public_ip Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Please resolve the conflict. |
Signed-off-by: Aylei <rayingecho@gmail.com>
@tennix done |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Aylei <rayingecho@gmail.com>
… into aliyun-multi-cluster
@tennix @onlymellb I've addressed some merge conflicts, could you please take a look again? |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
variable "tidb_cluster_chart_version" { | ||
description = "tidb-cluster chart version" | ||
default = "v1.0.0-beta.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use rc.1
?
* Refactor aliyun tf to multiple cloud Signed-off-by: Aylei <rayingecho@gmail.com> * Small fixes for terraform aws - fix hardcode chart version - fix unreachable bastion - adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking - add version check - disable pd node public_ip Signed-off-by: Aylei <rayingecho@gmail.com> * aliyun multiple cluster Signed-off-by: Aylei <rayingecho@gmail.com> * Modularization for AWS terraform scripts Signed-off-by: Aylei <rayingecho@gmail.com> * Refine README of AWS terraform Signed-off-by: Aylei <rayingecho@gmail.com> * Fix bastion ssh Signed-off-by: Aylei <rayingecho@gmail.com> * Alibaba cloud multiple clusters support Signed-off-by: Aylei <rayingecho@gmail.com> * Fix endpoints output Signed-off-by: Aylei <rayingecho@gmail.com> (cherry picked from commit 042b1a9)
* en: update tls doc for tiflash Signed-off-by: Ran <huangran@pingcap.com> * Apply suggestions from code review Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
What problem does this PR solve?
Add multiple tidb clusters management support in Alibaba Cloud
What is changed and how does it work?
Some reusable sub modules are created just like aws #650 , the scripts in
deploy/aliyun
are changed accordingly to compose one kubernetes cluster with one or more tidb clusters.Also, the
README
andREADME-CN
and removed and the users are redirected todocs-cn
anddocs
in favor of consistency.This PR is based on an un-merged PR #650 , so there will be some commits that are no belong to this PR, please follow this link to see the actual patch: https://github.com/pingcap/tidb-operator/pull/658/files/f07c30c58aa83b85d3aee167f84884d704085755
Check List
Tests
Related changes
Does this PR introduce a user-facing change?: