Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba Cloud multiple tidb clusters management support #658

Merged
merged 21 commits into from
Jul 23, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jul 14, 2019

What problem does this PR solve?

Add multiple tidb clusters management support in Alibaba Cloud

What is changed and how does it work?

Some reusable sub modules are created just like aws #650 , the scripts in deploy/aliyun are changed accordingly to compose one kubernetes cluster with one or more tidb clusters.

Also, the README and README-CN and removed and the users are redirected to docs-cn and docs in favor of consistency.

This PR is based on an un-merged PR #650 , so there will be some commits that are no belong to this PR, please follow this link to see the actual patch: https://github.com/pingcap/tidb-operator/pull/658/files/f07c30c58aa83b85d3aee167f84884d704085755

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

Does this PR introduce a user-facing change?:

Support multiple tidb clusters management in Alibaba Cloud.

aylei added 12 commits July 8, 2019 14:28
Signed-off-by: Aylei <rayingecho@gmail.com>
- fix hardcode chart version
- fix unreachable bastion
- adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking
- add version check
- disable pd node public_ip

Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
@tennix
Copy link
Member

tennix commented Jul 17, 2019

Please resolve the conflict.

@aylei
Copy link
Contributor Author

aylei commented Jul 17, 2019

@tennix done

@aylei
Copy link
Contributor Author

aylei commented Jul 17, 2019

/run-e2e-tests

tennix
tennix previously approved these changes Jul 19, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onlymellb
onlymellb previously approved these changes Jul 19, 2019
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei dismissed stale reviews from onlymellb and tennix via d976792 July 22, 2019 13:39
@aylei
Copy link
Contributor Author

aylei commented Jul 22, 2019

@tennix @onlymellb I've addressed some merge conflicts, could you please take a look again?

@aylei aylei added this to the v1.0.0 milestone Jul 22, 2019
@aylei aylei requested a review from tennix July 23, 2019 02:08
@aylei
Copy link
Contributor Author

aylei commented Jul 23, 2019

/run-e2e-tests

@aylei aylei requested a review from onlymellb July 23, 2019 02:56
Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


variable "tidb_cluster_chart_version" {
description = "tidb-cluster chart version"
default = "v1.0.0-beta.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use rc.1?

@tennix tennix merged commit 042b1a9 into pingcap:master Jul 23, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
* Refactor aliyun tf to multiple cloud

Signed-off-by: Aylei <rayingecho@gmail.com>

* Small fixes for terraform aws
- fix hardcode chart version
- fix unreachable bastion
- adjust tidb-cluster no-wait to avoid scheduled backup pvc blocking
- add version check
- disable pd node public_ip

Signed-off-by: Aylei <rayingecho@gmail.com>

* aliyun multiple cluster

Signed-off-by: Aylei <rayingecho@gmail.com>

* Modularization for AWS terraform scripts

Signed-off-by: Aylei <rayingecho@gmail.com>

* Refine README of AWS terraform

Signed-off-by: Aylei <rayingecho@gmail.com>

* Fix bastion ssh

Signed-off-by: Aylei <rayingecho@gmail.com>

* Alibaba cloud multiple clusters support

Signed-off-by: Aylei <rayingecho@gmail.com>

* Fix endpoints output

Signed-off-by: Aylei <rayingecho@gmail.com>
(cherry picked from commit 042b1a9)
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* en: update tls doc for tiflash

Signed-off-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants