Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nlb cross zone load balancing by default #686

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Jul 24, 2019

Signed-off-by: Aylei rayingecho@gmail.com

close #685

What problem does this PR solve?

enable nlb cross zone load balancing by default to avoid unbalanced traffic

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Enable AWS NLB  cross zone load balancing by default.

Signed-off-by: Aylei <rayingecho@gmail.com>
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei added the type/tinyfix typo or tiny fix label Jul 24, 2019
@aylei
Copy link
Contributor Author

aylei commented Jul 24, 2019

image
The load is balanced after enabling cross zone load balancing

@aylei aylei merged commit 62d7d26 into pingcap:master Jul 24, 2019
@aylei
Copy link
Contributor Author

aylei commented Jul 24, 2019

image
Comparing to this result, the former configuration is unbalanced

@aylei
Copy link
Contributor Author

aylei commented Jul 24, 2019

kubernetes/kubernetes#61064

This fix is introduced in 1.14 and I suspect it has not yet been back ported to the earlier kubernetes version

weekface pushed a commit that referenced this pull request Jul 29, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
(cherry picked from commit 62d7d26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/tinyfix typo or tiny fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS NLB cross-zone load balancing is not enabled
3 participants