Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade local-volume-provisioner to v2.3.2 #696

Merged
merged 3 commits into from
Aug 1, 2019

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jul 26, 2019

Signed-off-by: yeya24 yb532204897@gmail.com

What problem does this PR solve?

What is changed and how does it work?

Update local-volume-provisioner image to latest release.

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:


Signed-off-by: yeya24 <yb532204897@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2019

CLA assistant check
All committers have signed the CLA.

@aylei aylei added this to the v1.1 milestone Jul 26, 2019
@aylei
Copy link
Contributor

aylei commented Jul 26, 2019

/ok-to-test

@weekface
Copy link
Contributor

/run-e2e-tests

@gregwebs gregwebs requested a review from cofyc July 28, 2019 14:41
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24
Copy link
Contributor Author

yeya24 commented Jul 30, 2019

CI failed, do i need to change the e2e test code?
I am not sure that why here we need to patch this local pv.

patchPVCmd := fmt.Sprintf("kubectl get pv | grep %s | grep %s | awk '{print $1}' | "+

@cofyc
Copy link
Contributor

cofyc commented Jul 30, 2019

it's necessary, CI may fail because of temporary failures.

@weekface
Copy link
Contributor

@yeya24 The CI env was broken when i last run it. I will run the e2e test tonight again.

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #696 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #696   +/-   ##
=======================================
  Coverage   65.63%   65.63%           
=======================================
  Files          59       59           
  Lines        4502     4502           
=======================================
  Hits         2955     2955           
  Misses       1364     1364           
  Partials      183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3ad44...c264700. Read the comment docs.

@cofyc
Copy link
Contributor

cofyc commented Jul 31, 2019

/run-e2e-tests

@weekface weekface removed this from the v1.1 milestone Aug 1, 2019
@weekface weekface merged commit c67a901 into pingcap:master Aug 1, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

cherry pick to release-1.1 failed

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2019

cherry pick to release-1.0 in PR #723

@yeya24 yeya24 deleted the bump-local-provisioner-version branch August 1, 2019 23:51
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants