-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: inject a failure by pod annotation #716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful for testing scheduling failures. You can for example add it to monitor-deployment along with changing the scheduler to the custom scheduler.
tennix
reviewed
Aug 2, 2019
tennix
previously approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aylei
reviewed
Aug 2, 2019
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
weekface
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gregwebs
changed the title
scheduler: inject a failure by pod label
scheduler: inject a failure by pod annotation
Aug 2, 2019
/run-e2e-tests |
cherry pick to release-1.0 in PR #739 |
weekface
pushed a commit
that referenced
this pull request
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful for testing scheduling failures.
You can for example add it to monitor-deployment
along with changing the scheduler to the custom scheduler.
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
I tested as mentioned in the PR. I observed that no other pods had failed scheduling, including after deploying a second TiDB cluster.
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: