Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tidb-backup job reource limits #729

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Add tidb-backup job reource limits #729

merged 2 commits into from
Aug 12, 2019

Conversation

shonge
Copy link
Member

@shonge shonge commented Aug 4, 2019

What problem does this PR solve?

#284

What is changed and how does it work?

Add Tidb-backup helm chart job resource limits and requests.

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shonge
Copy link
Member Author

shonge commented Aug 4, 2019

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor

weekface commented Aug 5, 2019

/run-e2e-tests

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix PTAL

@xiaojingchen
Copy link
Contributor

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor

weekface commented Aug 9, 2019

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

/run-e2e-in-kind

@weekface weekface merged commit adab8c4 into pingcap:master Aug 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2019

cherry pick to release-1.0 in PR #761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants