Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add retry logic for LabelNodes function #735

Merged
merged 4 commits into from
Aug 12, 2019

Conversation

xiaojingchen
Copy link
Contributor

@xiaojingchen xiaojingchen commented Aug 6, 2019

What problem does this PR solve?

resolve bug that once label node failed cause e2e failed

What is changed and how does it work?

add retry logic for LabelNodes function

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change

Does this PR introduce a user-facing change?:

NONE

@xiaojingchen
Copy link
Contributor Author

/run-e2e-in-kind

1 similar comment
@xiaojingchen
Copy link
Contributor Author

/run-e2e-in-kind

@xiaojingchen xiaojingchen changed the title [WIP]add retry logic for NodeLable function e2e: add retry logic for LabelNodes function Aug 8, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@xiaojingchen
Copy link
Contributor Author

/run-e2e-test

@xiaojingchen
Copy link
Contributor Author

/run-e2e-in-kind

@xiaojingchen
Copy link
Contributor Author

@cofyc @shuijing198799 PTAL

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2019

CLA assistant check
All committers have signed the CLA.

@xiaojingchen
Copy link
Contributor Author

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 5347afc into pingcap:master Aug 12, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2019

cherry pick to release-1.0 in PR #754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants