Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a DRY_RUN setting to gcp-rm-unused-disks.sh #771

Merged
merged 1 commit into from
Aug 15, 2019

Conversation

gregwebs
Copy link
Contributor

@gregwebs gregwebs commented Aug 14, 2019

I think a release note was missing from a prior PR

GKE: add a script to delete unused disk

@gregwebs gregwebs requested a review from cofyc August 14, 2019 22:47
@gregwebs gregwebs merged commit 3ac0364 into pingcap:master Aug 15, 2019
@gregwebs gregwebs deleted the gcp-rm-unused-disk-dry-run branch August 15, 2019 21:00
@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2019

cherry pick to release-1.0 failed

@weekface
Copy link
Contributor

does this pr need to cherry-pick to release-1.0?

@gregwebs
Copy link
Contributor Author

No, I don't think this or any terraform need to be cherry-picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants