Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pump: prevent pump progress from an exit with 0 if the pump become offline (#769) #778

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 16, 2019

cherry-pick #769 to release-1.0


What problem does this PR solve?

prevent pump progress from an exit with 0 if the pump become offline
, because it will be online again if the pod get restarted by statefulset.

What is changed and how does it work?

Check List

Tests

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

prevent pump progress from an exit with 0 if the pump become `offline`

@weekface
Copy link
Contributor

/run-e2e-in-kind

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit f4b84af into pingcap:release-1.0 Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants