Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support restore tidb cluster from a specified scheduled backup dir #804

Merged

Conversation

onlymellb
Copy link
Contributor

What problem does this PR solve?

Make tidb-backup to support restore tidb clusters from a specified scheduled backup directory, while compatible with previous ad-hoc backup and restore method

What is changed and how does it work?

Work as before

Check List

Tests

  • Manual test

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

support restore tidb cluster from a specified scheduled backup directory

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

Do we need to add a stability test case to cover this feature?

@weekface
Copy link
Contributor

/run-e2e-in-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Contributor

sre-bot commented Aug 22, 2019

cherry pick to release-1.0 in PR #813

yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants