add recommendations options to mydumper #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-in-kind |
weekface
force-pushed
the
refine-mydumper-options
branch
2 times, most recently
from
ff42121
to
6baf0ad
Compare
weekface
force-pushed
the
refine-mydumper-options
branch
from
6baf0ad
to
bcd8987
Compare
|
/run-e2e-in-kind |
tennix
reviewed
Aug 27, 2019
| @@ -42,7 +42,7 @@ storage: | |||
| size: 100Gi | |||
|
|
|||
| # backupOptions is the options of mydumper https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options | |||
| backupOptions: "--verbose=3" | |||
| backupOptions: "-t 16 -F 256 --skip-tz-utc --verbose=3" | |||
There was a problem hiding this comment.
Add simple descriptions for these default options.
-tis thread count, larger thread count will speed up the backup, but may impact the performance of the upstream TiDB.-Fis the chunk size, a big table is partitioned into many chunks.
Other useful options are -B for database, and -T for tables. See https://github.com/maxbube/mydumper/blob/master/docs/mydumper_usage.rst#options for more options.
tennix
approved these changes
Aug 27, 2019
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 in PR #844 |
weekface
pushed a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add recommendations options to
mydumper:https://pingcap.com/docs/v3.0/how-to/maintain/backup-and-restore/#best-practices-of-full-backup-and-restoration-using-mydumper-loader
-t 16: means 16 threads are used to export the data.-F 64: means a table is partitioned into chunks and one chunk is 64MB.--skip-tz-utc: the purpose of adding this parameter is to ignore the inconsistency of time zone setting between MySQL and the data exporting machine and to disable automatic conversion.What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: