add tikvGCLifeTime option #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-in-kind |
aylei
reviewed
Aug 27, 2019
charts/tidb-backup/values.yaml
Outdated
| @@ -56,6 +56,9 @@ backupOptions: "--verbose=3" | |||
| initialCommitTs: "" | |||
| # restoreOptions is the options of loader https://www.pingcap.com/docs-cn/tools/loader/ | |||
| restoreOptions: "-t 16" | |||
| # The time limit during which data is retained for each GC when backup, in the format of Go Duration. | |||
| # When a GC happens, the current time minus this value is the safe point. | |||
| tikvGCLifeTime: 3h | |||
There was a problem hiding this comment.
I think it would better to use a long gc life time that impossible to reach as the default, e.g. 720h, which effectively "disable" the GC when backup in progress.
There was a problem hiding this comment.
Yes, I think this should not even be an option: the controller should automatically hold open the GC. Here we can have a timeout option to timeout the backup if it does not complete and document that it helps limit performance degradation during backup due to maintaining the GC. TiDB is supposed to get a backup lock feature eventually.
|
/run-e2e-in-kind |
1 similar comment
|
/run-e2e-in-kind |
weekface
commented
Aug 29, 2019
|
/run-e2e-in-kind |
tennix
reviewed
Aug 29, 2019
| @@ -15,8 +15,8 @@ fi | |||
| gc_life_time=`/usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "select variable_value from mysql.tidb where variable_name='tikv_gc_life_time';"` | |||
| echo "Old TiKV GC life time is ${gc_life_time}" | |||
|
|
|||
| echo "Increase TiKV GC life time to 3h" | |||
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='3h' where variable_name='tikv_gc_life_time';" | |||
| echo "Increase TiKV GC life time to {{ .Values.tikvGCLifeTime }}" | |||
There was a problem hiding this comment.
Suggested change
| echo "Increase TiKV GC life time to {{ .Values.tikvGCLifeTime }}" | |
| echo "Increase TiKV GC life time to {{ .Values.tikvGCLifeTime | default 720 }}" |
There was a problem hiding this comment.
When adding new variable to chart, always remember to set a default in case of users not providing the variable.
|
/run-e2e-in-kind |
tennix
reviewed
Aug 29, 2019
| @@ -15,8 +15,8 @@ fi | |||
| gc_life_time=`/usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "select variable_value from mysql.tidb where variable_name='tikv_gc_life_time';"` | |||
| echo "Old TiKV GC life time is ${gc_life_time}" | |||
|
|
|||
| echo "Increase TiKV GC life time to 3h" | |||
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='3h' where variable_name='tikv_gc_life_time';" | |||
| echo "Increase TiKV GC life time to {{ .Values.tikvGCLifeTime | default 720h }}" | |||
There was a problem hiding this comment.
This reports error when the value is not set:
Error: parse error in "tidb-cluster/templates/scripts/_start_scheduled_backup.sh.tpl": template: tidb-cluster/templates/scripts/_start_scheduled_backup.sh.tpl:22: bad number syntax: "720h"
tennix
reviewed
Aug 29, 2019
| echo "Increase TiKV GC life time to 3h" | ||
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='3h' where variable_name='tikv_gc_life_time';" | ||
| echo "Increase TiKV GC life time to {{ .Values.tikvGCLifeTime | default 720h }}" | ||
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='{{ .Values.tikvGCLifeTime | default 720h }}' where variable_name='tikv_gc_life_time';" |
There was a problem hiding this comment.
Suggested change
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='{{ .Values.tikvGCLifeTime | default 720h }}' where variable_name='tikv_gc_life_time';" | |
| /usr/bin/mysql -h${host} -P4000 -u${TIDB_USER} ${password_str} -Nse "update mysql.tidb set variable_value='{{ .Values.tikvGCLifeTime | default "720h" }}' where variable_name='tikv_gc_life_time';" |
|
/run-e2e-in-kind |
aylei
approved these changes
Aug 29, 2019
|
cherry pick to release-1.0 failed |
weekface
added a commit
to weekface/tidb-operator
that referenced
this pull request
Aug 29, 2019
(cherry picked from commit e22e480)
weekface
added a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: