Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tidb-cloud-backup image tag #846

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Update tidb-cloud-backup image tag #846

merged 2 commits into from
Aug 29, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Aug 29, 2019

What problem does this PR solve?

Update image tag to pingcap/tidb-cloud-backup:20190828, in this version, rclone is introduced to upload and download the backup data pingcap/tidb-cloud-backup#4

What is changed and how does it work?

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Update the default backup image to pingcap/tidb-cloud-backup:20190828

@aylei aylei requested review from weekface and tennix August 29, 2019 10:40
@weekface
Copy link
Contributor

/run-e2e-in-kind

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit ae006a6 into master Aug 29, 2019
@aylei
Copy link
Contributor Author

aylei commented Aug 29, 2019

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Aug 29, 2019

cherry pick to release-1.0 in PR #847

@tennix tennix deleted the update-backup-image branch February 15, 2020 00:21
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* multiple pv doc

* multiple pv doc

* optimze multiple pv doc

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* optimze multiple pv doc

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/configure-a-tidb-cluster.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants