Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tidb-operator crash when user modify sts upgrade strategy improperly #912

Conversation

onlymellb
Copy link
Contributor

What problem does this PR solve?

fix #863

What is changed and how does it work?

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

None

@weekface
Copy link
Contributor

/run-e2e-in-kind

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb
Copy link
Contributor Author

/run-e2e-in-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb onlymellb merged commit 79ba29b into pingcap:master Sep 30, 2019
@onlymellb onlymellb deleted the fix-operator-crash-when-modify-sts-update-strategy branch September 30, 2019 03:20
@sre-bot
Copy link
Contributor

sre-bot commented Sep 30, 2019

cherry pick to release-1.0 in PR #969

onlymellb pushed a commit that referenced this pull request Sep 30, 2019
…rly (#912) (#969)

* fix tidb-operator crash when user modify sts upgrade strategy incorrectly
onlymellb pushed a commit that referenced this pull request Sep 30, 2019
…fy sts upgrade (#973)

* fix tidb-operator crash when user modify sts upgrade strategy incorrectly

* add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the user manually modify tikv/tidb/pd sts casually, it may cause tidb-operator crash
4 participants