Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add provider and module versions for aws (#926) #929

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 18, 2019

cherry-pick #926 to release-1.0


What problem does this PR solve?

Some provider and module versions are missed in terraform scripts for AWS, which may cause new versions with breaking changes will be automatically installed by terraform init in future.
Refer to #895

What is changed and how does it work?

  • add provider and module versions for aws
  • fix some typos

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Deploy TiDB with terraform on AWS EKS

Code changes

  • Has terraform scripts change
  • Has documents change

Related changes

  • Need to cherry-pick to the release branch
    • cherry-pick-1.0
    • cherry-pick-1.1
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc cofyc merged commit 38ca535 into pingcap:release-1.0 Sep 23, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Win-Man <825895587@qq.com>
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants