Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: ensure pods unaffected when upgrading #955

Merged
merged 14 commits into from
Oct 16, 2019
Merged

test: ensure pods unaffected when upgrading #955

merged 14 commits into from
Oct 16, 2019

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@weekface weekface force-pushed the ensure-pods-unchanged-when-upgrade branch 2 times, most recently from 140661a to 9e74eac Compare September 25, 2019 09:42
@weekface weekface changed the title test: ensure pods unchanged when upgrading test: ensure pods unaffected when upgrading Sep 25, 2019
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface weekface force-pushed the ensure-pods-unchanged-when-upgrade branch from 9e74eac to 84f2680 Compare September 26, 2019 03:09
@xiaojingchen xiaojingchen mentioned this pull request Sep 27, 2019
Merged
@weekface weekface changed the title test: ensure pods unaffected when upgrading [DNM] test: ensure pods unaffected when upgrading Sep 27, 2019
@weekface weekface changed the title [DNM] test: ensure pods unaffected when upgrading test: ensure pods unaffected when upgrading Oct 10, 2019
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface weekface force-pushed the ensure-pods-unchanged-when-upgrade branch from e2f7932 to 39d9ede Compare October 10, 2019 07:23
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@tennix tennix added the test/stability stability tests label Oct 11, 2019
cofyc
cofyc reviewed Oct 12, 2019
View reviewed changes
tests/actions.go Outdated
@@ -469,7 +479,42 @@ func (oa *operatorActions) UpgradeOperator(info *OperatorConfig) error {
if err != nil {
return fmt.Errorf("failed to upgrade operator to: %s, %v, %s", info.Image, err, string(res))
}
return nil

time.Sleep(5 * time.Minute)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check ready status? that will be more efficient

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main purpose here is to prevent the pod from being rebuilt after updating the operator. After updating the operator, it may become ready soon, but it may take a while to rebuild all the pods. This time is not easy to grasp, so I just use sleep here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change it to wait.Poll

@weekface
Copy link
Contributor Author

This pr must wait for #896 merged.

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

1 similar comment
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface weekface force-pushed the ensure-pods-unchanged-when-upgrade branch from 8b8abc5 to 043d5de Compare October 12, 2019 11:35
cofyc
cofyc previously approved these changes Oct 13, 2019
View reviewed changes
@weekface
Copy link
Contributor Author

@tennix @xiaojingchen PTAL

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

2 similar comments
@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@cofyc
Copy link
Contributor

cofyc commented Oct 15, 2019

/run-e2e-in-kind

@tennix
Copy link
Member

tennix commented Oct 15, 2019

@weekface Please fix the conflict.

@tennix tennix added the status/ReqChange Comments need to be addressed label Oct 15, 2019
@weekface
Copy link
Contributor Author

conflict resolved.

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

tennix
tennix approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix removed the status/ReqChange Comments need to be addressed label Oct 15, 2019
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

4 similar comments
@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

@weekface
Copy link
Contributor Author

/run-e2e-in-kind

cofyc
cofyc approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Oct 16, 2019

/run-e2e-in-kind

@tennix tennix merged commit c58d543 into pingcap:master Oct 16, 2019
@weekface weekface mentioned this pull request Dec 5, 2019
Merged
weekface added a commit to weekface/tidb-operator that referenced this pull request Dec 5, 2019
@weekface
Merge branch 'release-1.0' into automated-cherry-pick-of-pingcap#955-…
4b706a6 
…release-1.0
weekface added a commit that referenced this pull request Dec 19, 2019
@weekface
Automated cherry pick of #955: ensure pods unchanged when upgrading (#…
67c5190 
…1286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@cofyc cofyc cofyc approved these changes

@xiaojingchen xiaojingchen Awaiting requested review from xiaojingchen

Assignees
No one assigned
Labels
test/stability stability tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stability case to ensure upgrade operator does not affect the clusters deployed
3 participants
@weekface @cofyc @tennix