-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename binlog proto #541
Rename binlog proto #541
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b2e2454
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e86322a
|
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
To solve the protocol buffer namespace conflict problem.
What is changed and how it works?
Rename binlog.proto to bl.proto
Check List
Tests
Code changes
Side effects
Related changes