-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the package manager to go modules #92
Conversation
why remove vendor? I think we can keep it |
i think it is redundant. |
vendor is cache here. consider network downloads in china |
ok,this is a reason that is difficult to refuse |
Must we use TiDB 2.0.8 or could we use the master version to get rid of the yacc parser? |
I think we should use master version in master branch. This repo would release with TiDB after 2.1 ga consistently |
LGTM |
@@ -0,0 +1,5 @@ | |||
TAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can run a script to clean these file, you can see hack/clean_vendor.sh in tidb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already fix it
LGTM |
Could |
What problem does this PR solve?
Change the package manager to go modules
What is changed and how it works?
we can use go mod to manage dependencies,old 'make xxx' command still work.
we can delete the 'vendor' dir,go mod and makefile will help us handle it