Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the package manager to go modules #92

Merged
merged 5 commits into from
Oct 30, 2018
Merged

Conversation

zier-one
Copy link
Contributor

What problem does this PR solve?

Change the package manager to go modules

What is changed and how it works?

we can use go mod to manage dependencies,old 'make xxx' command still work.
we can delete the 'vendor' dir,go mod and makefile will help us handle it

@WangXiangUSTC
Copy link
Contributor

why remove vendor? I think we can keep it

@zier-one
Copy link
Contributor Author

zier-one commented Oct 29, 2018

why remove vendor? I think we can keep it

i think it is redundant.
when we use 'make build' or 'make test',it can help us download dependencies and copy them to vendor.we can use vendor as usual,but i think it‘s not necessary to commit vendor in git repo,vendor shouldn't be managed by go.mod and git repo, however only be managed by go.mod.

@IANTHEREAL
Copy link
Collaborator

vendor is cache here. consider network downloads in china

@zier-one
Copy link
Contributor Author

vendor is cache here. consider network downloads in china

ok,this is a reason that is difficult to refuse

@kennytm
Copy link
Contributor

kennytm commented Oct 29, 2018

Must we use TiDB 2.0.8 or could we use the master version to get rid of the yacc parser?

@IANTHEREAL
Copy link
Collaborator

I think we should use master version in master branch. This repo would release with TiDB after 2.1 ga consistently

@IANTHEREAL
Copy link
Collaborator

LGTM

@@ -0,0 +1,5 @@
TAGS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can run a script to clean these file, you can see hack/clean_vendor.sh in tidb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already fix it

@WangXiangUSTC
Copy link
Contributor

LGTM

@zier-one zier-one merged commit 0a51ecb into pingcap:master Oct 30, 2018
@tiancaiamao
Copy link
Contributor

Could go get work with this repo now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants