Skip to content

Commit

Permalink
load data: skip physical mode test (#43959)
Browse files Browse the repository at this point in the history
ref #42930
  • Loading branch information
D3Hunter authored May 18, 2023
1 parent f636e44 commit 0620a9f
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 18 deletions.
1 change: 1 addition & 0 deletions tests/realtikvtest/loaddatatest/detach_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ var detachedCases = []detachedCase{
}

func (s *mockGCSSuite) TestSameBehaviourDetachedOrNot() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.testSameBehaviourDetachedOrNot(importer.LogicalImportMode)
s.testSameBehaviourDetachedOrNot(importer.PhysicalImportMode)
}
Expand Down
33 changes: 20 additions & 13 deletions tests/realtikvtest/loaddatatest/load_data_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func adjustOptions(options string, distributed bool) string {
}

func (s *mockGCSSuite) TestPhysicalMode() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -159,6 +160,7 @@ func (s *mockGCSSuite) TestPhysicalMode() {
}

func (s *mockGCSSuite) TestInputNull() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand All @@ -184,6 +186,7 @@ func (s *mockGCSSuite) TestInputNull() {
}

func (s *mockGCSSuite) TestIgnoreNLines() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{BucketName: "test-multi-load", Name: "skip-rows-1.csv"},
Content: []byte(`1,test1,11
Expand Down Expand Up @@ -238,7 +241,7 @@ func (s *mockGCSSuite) TestIgnoreNLines() {

func (s *mockGCSSuite) TestGeneratedColumns() {
s.testLoadDataForGeneratedColumns(importer.LogicalImportMode)
s.testLoadDataForGeneratedColumns(importer.PhysicalImportMode)
//s.testLoadDataForGeneratedColumns(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testLoadDataForGeneratedColumns(importMode string) {
Expand Down Expand Up @@ -288,6 +291,7 @@ func (s *mockGCSSuite) testLoadDataForGeneratedColumns(importMode string) {
}

func (s *mockGCSSuite) TestInputCountMisMatchAndDefault() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -322,6 +326,7 @@ func (s *mockGCSSuite) TestInputCountMisMatchAndDefault() {
}

func (s *mockGCSSuite) TestDeliverBytesRows() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "test-multi-load",
Expand Down Expand Up @@ -366,8 +371,8 @@ func (s *mockGCSSuite) TestDeliverBytesRows() {

func (s *mockGCSSuite) TestMultiValueIndex() {
s.testMultiValueIndex(importer.LogicalImportMode, false)
s.testMultiValueIndex(importer.PhysicalImportMode, false)
s.testMultiValueIndex(importer.PhysicalImportMode, true)
//s.testMultiValueIndex(importer.PhysicalImportMode, false)
//s.testMultiValueIndex(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testMultiValueIndex(importMode string, distributed bool) {
Expand Down Expand Up @@ -403,8 +408,8 @@ func (s *mockGCSSuite) testMultiValueIndex(importMode string, distributed bool)

func (s *mockGCSSuite) TestMixedCompression() {
s.testMixedCompression(importer.LogicalImportMode, false)
s.testMixedCompression(importer.PhysicalImportMode, false)
s.testMixedCompression(importer.PhysicalImportMode, true)
//s.testMixedCompression(importer.PhysicalImportMode, false)
//s.testMixedCompression(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testMixedCompression(importMode string, distributed bool) {
Expand Down Expand Up @@ -466,8 +471,8 @@ func (s *mockGCSSuite) testMixedCompression(importMode string, distributed bool)

func (s *mockGCSSuite) TestLoadSQLDump() {
s.testLoadSQLDump(importer.LogicalImportMode, false)
s.testLoadSQLDump(importer.PhysicalImportMode, false)
s.testLoadSQLDump(importer.PhysicalImportMode, true)
//s.testLoadSQLDump(importer.PhysicalImportMode, false)
//s.testLoadSQLDump(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testLoadSQLDump(importMode string, distributed bool) {
Expand Down Expand Up @@ -507,8 +512,8 @@ func (s *mockGCSSuite) testLoadSQLDump(importMode string, distributed bool) {

func (s *mockGCSSuite) TestGBK() {
s.testGBK(importer.LogicalImportMode, false)
s.testGBK(importer.PhysicalImportMode, false)
s.testGBK(importer.PhysicalImportMode, true)
//s.testGBK(importer.PhysicalImportMode, false)
//s.testGBK(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testGBK(importMode string, distributed bool) {
Expand Down Expand Up @@ -626,8 +631,8 @@ func (s *mockGCSSuite) testGBK(importMode string, distributed bool) {

func (s *mockGCSSuite) TestOtherCharset() {
s.testOtherCharset(importer.LogicalImportMode, false)
s.testOtherCharset(importer.PhysicalImportMode, false)
s.testOtherCharset(importer.PhysicalImportMode, true)
//s.testOtherCharset(importer.PhysicalImportMode, false)
//s.testOtherCharset(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testOtherCharset(importMode string, distributed bool) {
Expand Down Expand Up @@ -722,6 +727,7 @@ func (s *mockGCSSuite) testOtherCharset(importMode string, distributed bool) {
}

func (s *mockGCSSuite) TestMaxWriteSpeed() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.tk.MustExec("DROP DATABASE IF EXISTS load_test_write_speed;")
s.tk.MustExec("CREATE DATABASE load_test_write_speed;")
s.tk.MustExec(`CREATE TABLE load_test_write_speed.t(a int, b int)`)
Expand Down Expand Up @@ -764,6 +770,7 @@ func (s *mockGCSSuite) TestMaxWriteSpeed() {
}

func (s *mockGCSSuite) TestChecksumNotMatch() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.testChecksumNotMatch(importer.PhysicalImportMode, false)
s.testChecksumNotMatch(importer.PhysicalImportMode, true)
}
Expand Down Expand Up @@ -833,8 +840,8 @@ func (s *mockGCSSuite) testChecksumNotMatch(importMode string, distributed bool)

func (s *mockGCSSuite) TestColumnsAndUserVars() {
s.testColumnsAndUserVars(importer.LogicalImportMode, false)
s.testColumnsAndUserVars(importer.PhysicalImportMode, false)
s.testColumnsAndUserVars(importer.PhysicalImportMode, true)
//s.testColumnsAndUserVars(importer.PhysicalImportMode, false)
//s.testColumnsAndUserVars(importer.PhysicalImportMode, true)
}

func (s *mockGCSSuite) testColumnsAndUserVars(importMode string, distributed bool) {
Expand Down
2 changes: 1 addition & 1 deletion tests/realtikvtest/loaddatatest/one_parquet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var content []byte

func (s *mockGCSSuite) TestLoadParquet() {
s.testLoadParquet(importer.LogicalImportMode)
s.testLoadParquet(importer.PhysicalImportMode)
//s.testLoadParquet(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testLoadParquet(importMode string) {
Expand Down
2 changes: 1 addition & 1 deletion tests/realtikvtest/loaddatatest/operate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

func (s *mockGCSSuite) TestOperateRunningJob() {
s.testOperateRunningJob(importer.LogicalImportMode)
s.testOperateRunningJob(importer.PhysicalImportMode)
//s.testOperateRunningJob(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testOperateRunningJob(importMode string) {
Expand Down
1 change: 1 addition & 0 deletions tests/realtikvtest/loaddatatest/precheck_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
)

func (s *mockGCSSuite) TestPreCheckTableNotEmpty() {
s.T().Skip("feature will be moved into other statement, temporary skip this")
s.server.CreateObject(fakestorage.Object{
ObjectAttrs: fakestorage.ObjectAttrs{
BucketName: "precheck-tbl-empty",
Expand Down
5 changes: 2 additions & 3 deletions tests/realtikvtest/loaddatatest/show_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,7 @@ func (s *mockGCSSuite) simpleShowLoadDataJobs(importMode string) {
}

func (s *mockGCSSuite) TestSimpleShowLoadDataJobs() {
s.simpleShowLoadDataJobs(importer.PhysicalImportMode)

//s.simpleShowLoadDataJobs(importer.PhysicalImportMode)
s.simpleShowLoadDataJobs(importer.LogicalImportMode)

user := &auth.UserIdentity{
Expand Down Expand Up @@ -221,7 +220,7 @@ func (s *mockGCSSuite) TestSimpleShowLoadDataJobs() {

func (s *mockGCSSuite) TestInternalStatus() {
s.testInternalStatus(importer.LogicalImportMode)
s.testInternalStatus(importer.PhysicalImportMode)
//s.testInternalStatus(importer.PhysicalImportMode)
}

func (s *mockGCSSuite) testInternalStatus(importMode string) {
Expand Down

0 comments on commit 0620a9f

Please sign in to comment.