Improve test coverage to 100%

pingcap · Jan 29, 2021 · 0a1f635 · 0a1f635
1 parent aa6d46c
commit 0a1f635
Showing 1 changed file with 24 additions and 7 deletions.
diff --git a/errno/infoschema_test.go b/errno/infoschema_test.go
@@ -27,10 +27,13 @@ var _ = Suite(&testErrno{})
 
 type testErrno struct{}
 
-func (s *testErrno) TestGetSetSysVars(c *C) {
+func (s *testErrno) TestCopySafety(c *C) {
 
 	IncrementError(123, "user", "host")
 	IncrementError(321, "user2", "host2")
+	IncrementWarning(123, "user", "host")
+	IncrementWarning(999, "user", "host")
+	IncrementWarning(222, "u", "h")
 
 	globalCopy := GlobalStats()
 	userCopy := UserStats()
@@ -39,34 +42,48 @@ func (s *testErrno) TestGetSetSysVars(c *C) {
 	IncrementError(123, "user", "host")
 	IncrementError(999, "user2", "host2")
 	IncrementError(123, "user3", "host")
+	IncrementWarning(123, "user", "host")
+	IncrementWarning(222, "u", "h")
+	IncrementWarning(222, "a", "b")
+	IncrementWarning(333, "c", "d")
 
 	// global stats
 	c.Assert(stats.global[123].ErrorCount, Equals, 3)
 	c.Assert(globalCopy[123].ErrorCount, Equals, 1)
 
 	// user stats
-	c.Assert(len(stats.users), Equals, 3)
-	c.Assert(len(userCopy), Equals, 2)
+	c.Assert(len(stats.users), Equals, 6)
+	c.Assert(len(userCopy), Equals, 3)
 	c.Assert(stats.users["user"][123].ErrorCount, Equals, 2)
+	c.Assert(stats.users["user"][123].WarningCount, Equals, 2)
 	c.Assert(userCopy["user"][123].ErrorCount, Equals, 1)
+	c.Assert(userCopy["user"][123].WarningCount, Equals, 1)
 
 	// ensure there is no user3 in userCopy
 	_, ok := userCopy["user3"]
 	c.Assert(ok, IsFalse)
 	_, ok = stats.users["user3"]
 	c.Assert(ok, IsTrue)
+	_, ok = userCopy["a"]
+	c.Assert(ok, IsFalse)
+	_, ok = stats.users["a"]
+	c.Assert(ok, IsTrue)
 
 	// host stats
-	c.Assert(len(stats.hosts), Equals, 2)
-	c.Assert(len(hostCopy), Equals, 2)
+	c.Assert(len(stats.hosts), Equals, 5)
+	c.Assert(len(hostCopy), Equals, 3)
 	IncrementError(123, "user3", "newhost")
-	c.Assert(len(stats.hosts), Equals, 3)
-	c.Assert(len(hostCopy), Equals, 2)
+	c.Assert(len(stats.hosts), Equals, 6)
+	c.Assert(len(hostCopy), Equals, 3)
 
 	// ensure there is no newhost in hostCopy
 	_, ok = hostCopy["newhost"]
 	c.Assert(ok, IsFalse)
 	_, ok = stats.hosts["newhost"]
 	c.Assert(ok, IsTrue)
+	_, ok = hostCopy["b"]
+	c.Assert(ok, IsFalse)
+	_, ok = stats.hosts["b"]
+	c.Assert(ok, IsTrue)
 
 }