add more info in error

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
pingcap · Feb 7, 2023 · 12a5731 · 12a5731
1 parent 4392e9a
commit 12a5731
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/br/pkg/task/restore.go b/br/pkg/task/restore.go
@@ -491,7 +491,7 @@ func IsStreamRestore(cmdName string) bool {
 // RunRestore starts a restore task inside the current goroutine.
 func RunRestore(c context.Context, g glue.Glue, cmdName string, cfg *RestoreConfig) error {
 	if err := checkTaskExists(c, cfg); err != nil {
-		return errors.Trace(err)
+		return errors.Annotate(err, "failed to check task exits")
 	}
 
 	config.UpdateGlobal(func(conf *config.Config) {

diff --git a/br/pkg/task/stream.go b/br/pkg/task/stream.go
@@ -1045,7 +1045,11 @@ func checkTaskExists(ctx context.Context, cfg *RestoreConfig) error {
 		return err
 	}
 	cli := streamhelper.NewMetaDataClient(etcdCLI)
-	defer cli.Close()
+	defer func() {
+		if err := cli.Close(); err != nil {
+			log.Error("failed to close the etcd client", zap.Error(err))
+		}
+	}()
 	tasks, err := cli.GetAllTasks(ctx)
 	if err != nil {
 		return err