Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
XuHuaiyu committed Dec 2, 2021
1 parent 05a9528 commit 444d8c2
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions util/chunk/mutrow.go
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ func cleanColOfMutRow(col *Column) {
for i := range col.offsets {
col.offsets[i] = 0
}
col.nullBitmap[0] = 1
col.nullBitmap[0] = 0
}

// SetRow sets the MutRow with Row.
Expand All @@ -224,7 +224,6 @@ func (mr MutRow) SetRow(row Row) {
mrCol := mr.c.columns[colIdx]
cleanColOfMutRow(mrCol)
if rCol.IsNull(row.idx) {
mrCol.nullBitmap[0] = 0
continue
}
elemLen := len(rCol.elemBuf)
Expand All @@ -249,7 +248,6 @@ func (mr MutRow) SetValue(colIdx int, val interface{}) {
col := mr.c.columns[colIdx]
cleanColOfMutRow(col)
if val == nil {
col.nullBitmap[0] = 0
return
}
switch x := val.(type) {
Expand Down Expand Up @@ -297,7 +295,6 @@ func (mr MutRow) SetDatum(colIdx int, d types.Datum) {
col := mr.c.columns[colIdx]
cleanColOfMutRow(col)
if d.IsNull() {
col.nullBitmap[0] = 0
return
}
switch d.Kind() {
Expand Down

0 comments on commit 444d8c2

Please sign in to comment.