bindinfo: add timeout for loading binding from storage

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
pingcap · Mar 6, 2024 · 6531090 · 6531090
1 parent b309018
commit 6531090
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/pkg/bindinfo/binding_cache.go b/pkg/bindinfo/binding_cache.go
@@ -116,7 +116,7 @@ func (fbc *fuzzyBindingCache) loadFromStore(missingSQLDigest []string) {
 	for _, sqlDigest := range missingSQLDigest {
 		bindings, err := fbc.loadBindingFromStorageFunc(sqlDigest)
 		if err != nil {
-			logutil.BgLogger().Warn("loadBindingFromStorageFunc binding failed", zap.String("sqlDigest", sqlDigest), zap.Error(err))
+			logutil.BgLogger().Warn("loadBindingFromStorageFunc failed", zap.String("sqlDigest", sqlDigest), zap.Error(err))
 			continue
 		}
 		// put binding into the cache

diff --git a/pkg/bindinfo/global_handle.go b/pkg/bindinfo/global_handle.go
@@ -697,7 +697,6 @@ func (h *globalBindingHandle) LoadBindingsFromStorage(sqlDigest string) (Binding
 	select {
 	case result := <-resultChan:
 		if result.Err != nil {
-			logutil.BgLogger().Warn("fail to LoadBindingsFromStorageToCache", zap.Error(err))
 			return nil, result.Err
 		}
 		bindings := result.Val