executor: handle unsigned primary key for fast analyze (#11074) (#11099)

pingcap · Jul 6, 2019 · 731e426 · 731e426
1 parent c3346f2
commit 731e426
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/executor/analyze.go b/executor/analyze.go
@@ -813,6 +813,9 @@ func (e *AnalyzeFastExec) updateCollectorSamples(sValue []byte, sKey kv.Key, sam
  }
  v = types.NewIntDatum(key)
  }
+ if mysql.HasUnsignedFlag(e.pkInfo.Flag) {
+ v.SetUint64(uint64(v.GetInt64()))
+ }
  if e.collectors[0].Samples[samplePos] == nil {
  e.collectors[0].Samples[samplePos] = &statistics.SampleItem{}
  }

diff --git a/executor/analyze_test.go b/executor/analyze_test.go
@@ -290,6 +290,13 @@ func (s *testSuite1) TestFastAnalyze(c *C) {
  tk.MustQuery("explain select a, b from t1 where a = 1 and b = 2").Check(testkit.Rows(
  "IndexReader_6 2.00 root index:IndexScan_5",
  "└─IndexScan_5 2.00 cop table:t1, index:a, b, range:[1 2,1 2], keep order:false"))
+
+ tk.MustExec("create table t2 (a bigint unsigned, primary key(a))")
+ tk.MustExec("insert into t2 values (0), (18446744073709551615)")
+ tk.MustExec("analyze table t2")
+ tk.MustQuery("show stats_buckets where table_name = 't2'").Check(testkit.Rows(
+ "test t2 a 0 0 1 1 0 0",
+ "test t2 a 0 1 2 1 18446744073709551615 18446744073709551615"))
 }
 
 func (s *testSuite1) TestAnalyzeIncremental(c *C) {