statistic: improve ipv6 for analyze job meta (#45177) (#45188)

ref #43260
pingcap · Nov 6, 2023 · 8b2e9f9 · 8b2e9f9
1 parent 4d5d89b
commit 8b2e9f9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/executor/analyze.go b/executor/analyze.go
@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"math"
 	"math/rand"
+	"net"
 	"sort"
 	"strconv"
 	"strings"
@@ -2489,7 +2490,7 @@ func AddNewAnalyzeJob(ctx sessionctx.Context, job *statistics.AnalyzeJob) {
 		logutil.BgLogger().Error("failed to get server info", zap.Error(err))
 		instance = "unknown"
 	} else {
-		instance = fmt.Sprintf("%s:%d", serverInfo.IP, serverInfo.Port)
+		instance = net.JoinHostPort(serverInfo.IP, strconv.Itoa(int(serverInfo.Port)))
 	}
 	statsHandle := domain.GetDomain(ctx).StatsHandle()
 	err = statsHandle.InsertAnalyzeJob(job, instance, ctx.GetSessionVars().ConnectionID)