table: move add TTL insert rows metrics code out of table package (#5…

…4521) ref #54397
pingcap · Jul 9, 2024 · 8f0db6f · 8f0db6f
1 parent 2c72c39
commit 8f0db6f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/pkg/executor/insert_common.go b/pkg/executor/insert_common.go
@@ -1437,6 +1437,12 @@ func (e *InsertValues) addRecordWithAutoIDHint(
  }
  }
  }
+
+ if e.Table.Meta().TTLInfo != nil {
+ // update the TTL metrics if the table is a TTL table
+ vars.TxnCtx.InsertTTLRowsCount++
+ }
+
  return nil
 }
 

diff --git a/pkg/table/tables/tables.go b/pkg/table/tables/tables.go
@@ -1069,10 +1069,6 @@ func (t *TableCommon) AddRecord(sctx table.MutateContext, r []types.Datum, opts
  return recordID, nil
  }
 
- if shouldIncreaseTTLMetricCount(t.meta) {
- sessVars.TxnCtx.InsertTTLRowsCount += 1
- }
-
  colSizeBuffer := sctx.GetMutateBuffers().GetColSizeDeltaBufferWithCap(len(t.Cols()))
  for id, col := range t.Cols() {
  size, err := codec.EstimateValueSize(sc.TypeCtx(), r[id])
@@ -1742,10 +1738,6 @@ func shouldWriteBinlog(vars *variable.SessionVars, tblInfo *model.TableInfo) boo
  return !vars.InRestrictedSQL
 }
 
-func shouldIncreaseTTLMetricCount(tblInfo *model.TableInfo) bool {
- return tblInfo.TTLInfo != nil
-}
-
 func (t *TableCommon) getMutation(ctx table.MutateContext) *binlog.TableMutation {
  return ctx.StmtGetMutation(t.tableID)
 }