Skip to content

Commit

Permalink
update comment
Browse files Browse the repository at this point in the history
Signed-off-by: ekexium <eke@fastmail.com>
  • Loading branch information
ekexium committed Jan 29, 2024
1 parent 05d571a commit 9bd7f36
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pkg/store/driver/error/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ func ToTiDBErr(err error) error {
return ErrTiFlashServerTimeout
}

// TODO: the definitions of the signals are in executor
if stderrs.Is(err, tikverr.ErrQueryInterruptedWithSignal{Signal: sqlkiller.QueryInterrupted}) {
// TODO: This error is defined here, while others are using exeerrors. Maybe unify them?
return ErrQueryInterrupted
Expand All @@ -127,11 +126,11 @@ func ToTiDBErr(err error) error {
return exeerrors.ErrMaxExecTimeExceeded.GenWithStackByArgs()
}
if stderrs.Is(err, tikverr.ErrQueryInterruptedWithSignal{Signal: sqlkiller.QueryMemoryExceeded}) {
// connection id is unkonwn in client
// connection id is unkonwn in client, which should be logged or filled by upper layers
return exeerrors.ErrMemoryExceedForQuery.GenWithStackByArgs(-1)
}
if stderrs.Is(err, tikverr.ErrQueryInterruptedWithSignal{Signal: sqlkiller.ServerMemoryExceeded}) {
// connection id is unknown in client
// connection id is unknown in client, which should be logged or filled by upper layers
return exeerrors.ErrMemoryExceedForInstance.GenWithStackByArgs(-1)
}

Expand Down

0 comments on commit 9bd7f36

Please sign in to comment.