-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
*: add pushdown for ShowStmt and implement for show columns (#31742)
close #29910
- Loading branch information
1 parent
a15f4fd
commit ad1c5b5
Showing
11 changed files
with
243 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| // Copyright 2022 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package core | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/pingcap/tidb/parser/ast" | ||
| driver "github.com/pingcap/tidb/types/parser_driver" | ||
| "github.com/pingcap/tidb/util/collate" | ||
| "github.com/pingcap/tidb/util/stringutil" | ||
| ) | ||
|
|
||
| var _ ShowPredicateExtractor = &ShowColumnsTableExtractor{} | ||
|
|
||
| // ShowPredicateExtractor is used to extract some predicates from `PatternLikeExpr` clause | ||
| // and push the predicates down to the data retrieving on reading memory table stage when use ShowStmt. | ||
| // | ||
| // e.g: | ||
| // SHOW COLUMNS FROM t LIKE '%abc%' | ||
| // We must request all components from the memory table, and filter the result by the PatternLikeExpr predicate. | ||
| // | ||
| // it is a way to fix https://github.com/pingcap/tidb/issues/29910. | ||
| type ShowPredicateExtractor interface { | ||
| // Extracts predicates which can be pushed down and returns whether the extractor can extract predicates. | ||
| Extract(show *ast.ShowStmt) bool | ||
| explainInfo() string | ||
| } | ||
|
|
||
| // ShowColumnsTableExtractor is used to extract some predicates of tables table. | ||
| type ShowColumnsTableExtractor struct { | ||
| Field string | ||
|
|
||
| FieldPatterns string | ||
| } | ||
|
|
||
| // Extract implements the MemTablePredicateExtractor Extract interface | ||
| func (e *ShowColumnsTableExtractor) Extract(show *ast.ShowStmt) bool { | ||
| if show.Pattern != nil && show.Pattern.Pattern != nil { | ||
| pattern := show.Pattern | ||
| switch pattern.Pattern.(type) { | ||
| case *driver.ValueExpr: | ||
| // It is used in `SHOW COLUMNS FROM t LIKE `abc``. | ||
| ptn := pattern.Pattern.(*driver.ValueExpr).GetString() | ||
| patValue, patTypes := stringutil.CompilePattern(ptn, pattern.Escape) | ||
| if !collate.NewCollationEnabled() && stringutil.IsExactMatch(patTypes) { | ||
| e.Field = strings.ToLower(string(patValue)) | ||
| return true | ||
| } | ||
| // (?i) mean to be case-insensitive. | ||
| e.FieldPatterns = "(?i)" + stringutil.CompileLike2Regexp(string(patValue)) | ||
| return true | ||
| case *ast.ColumnNameExpr: | ||
| // It is used in `SHOW COLUMNS FROM t LIKE abc`. | ||
| // MySQL do not support this syntax and return the error. | ||
| return false | ||
| } | ||
| } else if show.Column != nil && show.Column.Name.L != "" { | ||
| // it is used in `DESCRIBE t COLUMN`. | ||
| e.Field = show.Column.Name.L | ||
| return true | ||
| } | ||
| return false | ||
|
|
||
| } | ||
|
|
||
| func (e *ShowColumnsTableExtractor) explainInfo() string { | ||
| r := new(bytes.Buffer) | ||
| if len(e.Field) > 0 { | ||
| r.WriteString(fmt.Sprintf("field:[%s], ", e.Field)) | ||
| } | ||
|
|
||
| if len(e.FieldPatterns) > 0 { | ||
| r.WriteString(fmt.Sprintf("field_pattern:[%s], ", e.FieldPatterns)) | ||
| } | ||
|
|
||
| // remove the last ", " in the message info | ||
| s := r.String() | ||
| if len(s) > 2 { | ||
| return s[:len(s)-2] | ||
| } | ||
| return s | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| // Copyright 2022 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package core_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/pingcap/tidb/parser" | ||
| "github.com/pingcap/tidb/planner/core" | ||
| "github.com/pingcap/tidb/testkit" | ||
| "github.com/pingcap/tidb/util/hint" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestPlanStringer(t *testing.T) { | ||
| store, clean := testkit.CreateMockStore(t) | ||
| defer clean() | ||
| tk := testkit.NewTestKit(t, store) | ||
|
|
||
| tk.MustExec("use test") | ||
| tk.MustExec("create table t(a int, b int, c int, index idx(a))") | ||
| tests := []struct { | ||
| sql string | ||
| plan string | ||
| }{ | ||
| { | ||
| sql: "show columns from t like 'a'", | ||
| plan: "Show(field:[a])", | ||
| }, | ||
| { | ||
| sql: "show columns from t like 'a%'", | ||
| plan: "Show(field_pattern:[(?i)a.*])", | ||
| }, | ||
| { | ||
| sql: "show columns from t where field = 'a'", | ||
| plan: "Show->Sel([eq(Column#13, a)])->Projection", | ||
| }, | ||
| { | ||
| sql: "desc t", | ||
| plan: "Show", | ||
| }, | ||
| { | ||
| sql: "desc t a", | ||
| plan: "Show(field:[a])", | ||
| }, | ||
| } | ||
| parser := parser.New() | ||
| for _, tt := range tests { | ||
| stmt, err := parser.ParseOneStmt(tt.sql, "", "") | ||
| require.NoError(t, err, "for %s", tt.sql) | ||
| ret := &core.PreprocessorReturn{} | ||
| builder, _ := core.NewPlanBuilder().Init(tk.Session(), ret.InfoSchema, &hint.BlockHintProcessor{}) | ||
| p, err := builder.Build(context.TODO(), stmt) | ||
| require.NoError(t, err, "for %s", tt.sql) | ||
| p, err = core.LogicalOptimize(context.TODO(), builder.GetOptFlag(), p.(core.LogicalPlan)) | ||
| require.NoError(t, err, "for %s", tt.sql) | ||
| require.Equal(t, tt.plan, core.ToString(p)) | ||
| } | ||
| } |