Skip to content

Commit

Permalink
address the comment
Browse files Browse the repository at this point in the history
Signed-off-by: yisaer <disxiaofei@163.com>
  • Loading branch information
Yisaer committed Nov 26, 2021
1 parent dc6d42d commit cd6ec77
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions planner/core/rule_aggregation_elimination.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,13 @@ func (a *aggregationEliminateChecker) tryToEliminateDistinct(agg *LogicalAggrega
}

func appendAggregationEliminateTraceStep(agg *LogicalAggregation, uniqueKey expression.KeyInfo, opt *logicalOptimizeOp) {
if opt.tracer == nil {
return
}
opt.appendStepToCurrent(agg.ID(), agg.TP(),
fmt.Sprintf("%s is unique key", uniqueKey.String()),
"aggregation eliminated to projection")
}

func appendDistinctEliminateTraceStep(agg *LogicalAggregation, uniqueKey expression.KeyInfo, af *aggregation.AggFuncDesc,
opt *logicalOptimizeOp) {
if opt.tracer == nil {
return
}
opt.appendStepToCurrent(agg.ID(), agg.TP(),
fmt.Sprintf("%s is unique key", uniqueKey.String()),
fmt.Sprintf("agg[%s]'s distinct eliminated", af.Name))
Expand Down

0 comments on commit cd6ec77

Please sign in to comment.