Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MySQL X Protocol #1109

Closed
ngaut opened this issue Apr 18, 2016 · 3 comments
Closed

Support MySQL X Protocol #1109

ngaut opened this issue Apr 18, 2016 · 3 comments
Labels
feature/rejected This feature request is rejected by product managers type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@ngaut
Copy link
Member

ngaut commented Apr 18, 2016

Ref to : http://mysqlserverteam.com/mysql-5-7-12-part-2-improving-the-mysql-protocol/

@ngaut ngaut added the type/enhancement The issue or PR belongs to an enhancement. label Apr 18, 2016
@ngaut ngaut added this to the met milestone Apr 18, 2016
@ngaut ngaut removed this from the met milestone Jul 12, 2016
@ghost ghost changed the title Support Async APIs for MySQL Support MySQL X Protocol Jul 11, 2020
@zz-jason zz-jason added the type/feature-request Categorizes issue or PR as related to a new feature. label Jul 22, 2020
@zz-jason zz-jason added feature/reviewing This feature request is reviewing by product managers feature/discussing This feature request is discussing among product managers and removed feature/reviewing This feature request is reviewing by product managers labels Aug 6, 2020
@scsldb scsldb closed this as completed Aug 28, 2020
@zz-jason zz-jason added feature/accepted This feature request is accepted by product managers and removed feature/discussing This feature request is discussing among product managers labels Aug 28, 2020
@ghost
Copy link

ghost commented Aug 28, 2020

It's not clear by the tags, was the intention to accept or reject this feature?

@scsldb
Copy link

scsldb commented Aug 28, 2020

GPL V3 licenses are at risk and cannot be supported at this time.

@zz-jason zz-jason added feature/rejected This feature request is rejected by product managers and removed feature/accepted This feature request is accepted by product managers labels Sep 1, 2020
xhebox pushed a commit to xhebox/tidb that referenced this issue Sep 28, 2021
xhebox pushed a commit to xhebox/tidb that referenced this issue Oct 8, 2021
@dveeden
Copy link
Contributor

dveeden commented Oct 28, 2021

GPL V3 licenses are at risk and cannot be supported at this time.

[dvaneeden@dve-carbon server]$ for f in ./plugin/x/protocol/protobuf/*.proto; do head -23 $f | md5sum; done
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
b044874c631d3166f80ae585cf3491ef  -
[dvaneeden@dve-carbon server]$ head -23 ./plugin/x/protocol/protobuf/mysqlx.proto 
/*
 * Copyright (c) 2015, 2021, Oracle and/or its affiliates.
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License, version 2.0,
 * as published by the Free Software Foundation.
 *
 * This program is also distributed with certain software (including
 * but not limited to OpenSSL) that is licensed under separate terms,
 * as designated in a particular file or component or in included license
 * documentation.  The authors of MySQL hereby grant you an additional
 * permission to link the program and your derivative works with the
 * separately licensed software that they have included with MySQL.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License, version 2.0, for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
 */
[dvaneeden@dve-carbon server]$ cat MYSQL_VERSION 
MYSQL_VERSION_MAJOR=8
MYSQL_VERSION_MINOR=0
MYSQL_VERSION_PATCH=27
MYSQL_VERSION_EXTRA=

This doesn't look like GPLv3, but GPLv2 to me. However https://www.apache.org/licenses/GPL-compatibility.html suggests that this doesn't make a difference in this case.

Confusingly enough there is this:
https://github.com/mysql/mysql-server/blob/3290a66c89eb1625a7058e0ef732432b6952b435/plugin/x/protocol/protobuf/mysqlx.proto#L304-L305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rejected This feature request is rejected by product managers type/enhancement The issue or PR belongs to an enhancement. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants