Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filters for SPM baseline capture functionality #15655

Closed
Tracked by #25970
eurekaka opened this issue Mar 25, 2020 · 0 comments · Fixed by #26294
Closed
Tracked by #25970

add filters for SPM baseline capture functionality #15655

eurekaka opened this issue Mar 25, 2020 · 0 comments · Fixed by #26294
Labels
epic/sql-plan-management priority/P1 The issue has P1 priority. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Milestone
Requirement pool

Comments

@eurekaka
Copy link
Contributor

Development Task

Currently, if tidb_capture_plan_baselines is enabled, SPM would capture SQL patterns which occur more than once and build a baseline binding for it if there doesn't exist one. This would be annoying if users enable this feature in product environment, because there may be huge amount of bindings built.

We can let users define filter / rules to constraint the capture behavior, e.g, only capture baselines for specified tables, or specified connection.
@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Mar 25, 2020
@zz-jason zz-jason mentioned this issue May 28, 2020
Open
5 tasks
@zz-jason zz-jason added this to the v5.0-alpha milestone Jun 15, 2020
@scsldb scsldb added the priority/P0 The issue has P0 priority. label Jun 15, 2020
@zz-jason zz-jason added priority/P1 The issue has P1 priority. and removed priority/P0 The issue has P0 priority. labels Jul 7, 2020
@scsldb scsldb modified the milestones: v5.0.0-alpha, pools Jul 15, 2020
@eurekaka eurekaka mentioned this issue Jul 5, 2021
Open
12 tasks
This was referenced Jul 14, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic/sql-plan-management priority/P1 The issue has P1 priority. sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
Requirement pool
Development

Successfully merging a pull request may close this issue.

*: support user defined filters for baseline capture eurekaka/tidb
3 participants
@zz-jason @scsldb @eurekaka