-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support user defined filters for baseline capture #26294
Conversation
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
d4de226
to
c6f1c8d
Compare
87aeaf7
to
c225719
Compare
c225719
to
c9958cc
Compare
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cbc831a
|
@eurekaka: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #15655
Problem Summary:
New functionality for baseline capture.
What is changed and how it works?
What's Changed:
mysql.capture_plan_baselines_blacklist
mysql.capture_plan_baselines_blacklist
to manipulate the capture filterid
,filter_type
, andfilter_value
, currently, onlytable
/db
/frequency
type values are supported, other unknown types would be ignored with a warning message in the logtable
type values should be liketest.t
, i.e, database name should be specified for the table name, otherwise, it would be ignored with a warning in the logfrequency
type value is 3, then all the queries which occur less than 4 times would be ignored in the capture; if there are multiplefrequency
rows, the capture filter would choose the largest onemysql.capture_plan_baselines_blacklist
, so no reload operation is needed once the table data is modified; the baseline capture would read the table each timeCheck List
Tests
Side effects
N/A
Documentation
Release note