Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support user defined filters for baseline capture #26294

Merged
merged 5 commits into from
Aug 18, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Jul 16, 2021

What problem does this PR solve?

Issue Number: close #15655

Problem Summary:

New functionality for baseline capture.

What is changed and how it works?

What's Changed:

  • add a new system table mysql.capture_plan_baselines_blacklist
  • users can insert / update / delete rows in mysql.capture_plan_baselines_blacklist to manipulate the capture filter
  • the table contains 3 columns, id, filter_type, and filter_value, currently, only table / db / frequency type values are supported, other unknown types would be ignored with a warning message in the log
  • table type values should be like test.t, i.e, database name should be specified for the table name, otherwise, it would be ignored with a warning in the log
  • if frequency type value is 3, then all the queries which occur less than 4 times would be ignored in the capture; if there are multiple frequency rows, the capture filter would choose the largest one
  • there is no cache for the rows in mysql.capture_plan_baselines_blacklist, so no reload operation is needed once the table data is modified; the baseline capture would read the table each time

Check List

Tests

  • Unit test

Side effects

N/A

Documentation

  • Affects user behaviors

Release note

  • Support user defined filters for baseline capture

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner epic/sql-plan-management labels Jul 16, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 16, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jul 16, 2021
@eurekaka
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@eurekaka
Copy link
Contributor Author

/run-check_dev_2

@github-actions github-actions bot added the sig/execution SIG execution label Jul 16, 2021
@eurekaka eurekaka removed sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 16, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 19, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2021
@eurekaka eurekaka force-pushed the capture_filter branch 3 times, most recently from 87aeaf7 to c225719 Compare August 5, 2021 08:59
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2021
@eurekaka
Copy link
Contributor Author

/run-check_dev_2

@eurekaka eurekaka requested a review from winoros August 18, 2021 02:25
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2021
@eurekaka
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cbc831a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2021
@ti-chi-bot
Copy link
Member

@eurekaka: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5c1081f into pingcap:master Aug 18, 2021
@eurekaka eurekaka deleted the capture_filter branch August 18, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/sql-plan-management sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add filters for SPM baseline capture functionality
4 participants