Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discard feedbacks from delete / update statements #17438

Closed
eurekaka opened this issue May 27, 2020 · 1 comment · Fixed by #17452, #17840, #17841, #17842 or #17843
Closed

discard feedbacks from delete / update statements #17438

eurekaka opened this issue May 27, 2020 · 1 comment · Fixed by #17452, #17840, #17841, #17842 or #17843
Assignees
@eurekaka
Labels
component/statistics epic/query-feedback-GA type/enhancement The issue or PR belongs to an enhancement.
Milestone
v4.0.2

Comments

@eurekaka
Copy link
Contributor

Development Task

Currently, we store feedbacks of a query into SessionStatsCollector in the Close method of IndexReaderExec / TableReaderExec / IndexLookupReaderExec, so for queries like delete from t where a > 1, the feedbacks of range (1, +inf) would be stored as well, but those rows are deleted by this query actually, i.e, those feedbacks are obsolete when they are generated.

Skip storing feedbacks from delete. For update, the updated columns may be covered by the filter, or not covered, for simplicity, we skip storing feedbacks for update as well.
@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/statistics labels May 27, 2020
@eurekaka eurekaka self-assigned this May 27, 2020
@eurekaka eurekaka mentioned this issue May 27, 2020
Merged
@zz-jason zz-jason modified the milestones: v4.0.1, v4.0.2 Jun 2, 2020
This was referenced Jun 8, 2020
Merged
Merged
Merged
Merged
@SunRunAway
Copy link
Contributor

@eurekaka Please cherry-pick the related PR.

This was linked to pull requests Jun 11, 2020
session/statistics: discard feedbacks from delete / update (#17452) #17840
Merged
session/statistics: discard feedbacks from delete / update (#17452) #17841
Merged
session/statistics: discard feedbacks from delete / update (#17452) #17842
Merged
session/statistics: discard feedbacks from `delete ... (#17452) #17843
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eurekaka eurekaka

Labels
component/statistics epic/query-feedback-GA type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
v4.0.2
3 participants
@SunRunAway @zz-jason @eurekaka