Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query backoff detail in SLOW_QUERY #17938

Closed
crazycs520 opened this issue Jun 11, 2020 · 3 comments
Closed

Support query backoff detail in SLOW_QUERY #17938

crazycs520 opened this issue Jun 11, 2020 · 3 comments
Labels
epic/slow-query help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@crazycs520
Copy link
Contributor

Background

#13770 records the backoff detail in slow log, such as below:

# Cop_backoff_regionMiss_total_times: 200 Cop_backoff_regionMiss_total_time: 0.2 Cop_backoff_regionMiss_max_time: 0.2 Cop_backoff_regionMiss_max_addr: 127.0.0.1 Cop_backoff_regionMiss_avg_time: 0.2 Cop_backoff_regionMiss_p90_time: 0.2
# Cop_backoff_rpcPD_total_times: 200 Cop_backoff_rpcPD_total_time: 0.2 Cop_backoff_rpcPD_max_time: 0.2 Cop_backoff_rpcPD_max_addr: 127.0.0.1 Cop_backoff_rpcPD_avg_time: 0.2 Cop_backoff_rpcPD_p90_time: 0.2
# Cop_backoff_rpcTiKV_total_times: 200 Cop_backoff_rpcTiKV_total_time: 0.2 Cop_backoff_rpcTiKV_max_time: 0.2 Cop_backoff_rpcTiKV_max_addr: 127.0.0.1 Cop_backoff_rpcTiKV_avg_time: 0.2 Cop_backoff_rpcTiKV_p90_time: 0.2

But I can't query this backoff-detail from SLOW_QUERY/CLUSTER_SLOW_QUERY.

Task

Maybe we can add a Backoff_detail column, the type can be varchar(4096), then we can store the backoff detail in this column.

@crazycs520 crazycs520 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. difficulty/easy epic/slow-query labels Jun 11, 2020
@crazycs520
Copy link
Contributor Author

@jyz0309 PTAL

@jyz0309
Copy link
Contributor

jyz0309 commented Sep 24, 2020

/pick-up

@ti-challenge-bot
Copy link

It is not a pickable issue!

More

Tip : If you want this issue to be picked, you need to add a challenge-program label to it.

Warning: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/slow-query help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants