executor: show back-off details in slow log #13770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13770 +/- ##
===========================================
Coverage 80.3693% 80.3693%
===========================================
Files 475 475
Lines 118901 118901
===========================================
Hits 95560 95560
Misses 15881 15881
Partials 7460 7460 |
|
/run-all-tests |
|
PTAL~ @lysu @SunRunAway @XuHuaiyu @wshwsh12 |
lysu
reviewed
Dec 3, 2019
|
/bench |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 5a589c9994b568368e185602e54bbcfffb0f4c44
+++ tidb: 081ab797ce7ab56526781666cd6dd22e40a0c1bb
tikv: 1674fd02576cf0fdb8150421322462d5eff1db81
pd: 895ccdb38eaf12f2421fcd03e0661f00447542e3
================================================================================
oltp_update_non_index:
* QPS: 4709.26 ± 0.25% (std=9.55) delta: 0.17% (p=0.268)
* Latency p50: 27.18 ± 0.23% (std=0.05) delta: -0.17%
* Latency p99: 43.20 ± 3.12% (std=1.01) delta: -2.66%
oltp_insert:
* QPS: 4782.02 ± 0.21% (std=6.72) delta: 0.36% (p=0.034)
* Latency p50: 26.76 ± 0.22% (std=0.04) delta: -0.36%
* Latency p99: 45.83 ± 5.48% (std=1.76) delta: -3.51%
oltp_read_write:
* QPS: 15583.46 ± 0.07% (std=7.34) delta: 1.35% (p=0.011)
* Latency p50: 164.63 ± 0.12% (std=0.15) delta: -1.32%
* Latency p99: 303.50 ± 5.31% (std=10.10) delta: -0.86%
oltp_update_index:
* QPS: 4259.34 ± 0.07% (std=2.12) delta: 0.01% (p=0.795)
* Latency p50: 30.05 ± 0.07% (std=0.01) delta: -0.02%
* Latency p99: 53.37 ± 0.90% (std=0.48) delta: 0.43%
oltp_point_select:
* QPS: 39586.89 ± 0.13% (std=32.26) delta: 0.08% (p=0.748)
* Latency p50: 3.23 ± 0.00% (std=0.00) delta: -0.15%
* Latency p99: 10.00 ± 0.90% (std=0.09) delta: 0.00%
|
qw4990
force-pushed
the
backoff-details
branch
from
081ab79 to
cb31b02
Compare
qw4990
added
status/can-merge
|
/run-all-tests |
|
@qw4990 merge failed. |
|
/rebuild |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Show back-off details in slow log.
After this PR, you can see this information in slow log:
Check List
Tests