v4.0.11 upgrade to v5.0.0, user privileges changed

[seiya-annie]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1. create user quatest with create privi on v4.0.11
   MySQL [(none)]> create user qatest;grant Create on . to qatest;
   Query OK, 0 rows affected (0.03 sec)
2. upgrade to v5.0.0
3. check user privileges

2. What did you expect to see? (Required)

MySQL [(none)]> show grants for qatest;
+-------------------------------------+
| Grants for qatest@% |
+-------------------------------------+
| GRANT Create ON . TO 'qatest'@'%' |
+-------------------------------------+
1 row in set (0.00 sec)

3. What did you see instead (Required)

MySQL [(none)]> show grants for qatest;
+--------------------------------------------------------------------------+
| Grants for qatest@% |
+--------------------------------------------------------------------------+
| GRANT Create,REPLICATION CLIENT,REPLICATION SLAVE ON . TO 'qatest'@'%' |
+--------------------------------------------------------------------------+
1 row in set (0.00 sec)

4. What is your TiDB version? (Required)

MySQL [test]> SELECT tidb_version() ;
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version() |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v5.0.0
Edition: Community
Git Commit Hash: 46f5f21
Git Branch: heads/refs/tags/v5.0.0
UTC Build Time: 2021-03-15 06:21:59
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

MySQL [test]>

[zimulala]

PTAL @bb7133

[ti-srebot]

Please edit this comment or add a new comment to complete the following information

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

The connection verification function does not handle the malformed input well, when the input data is in valid, tidb panic.

2. Symptom (optional)

See the goroutine panic stack and check where it happen.

3. All Trigger Conditions (optional)

Still unclear on which situration the user input is invalid.

4. Workaround (optional)

NA

5. Affected versions

[v4.0.1:v4.0.12]

6. Fixed versions

v4.0.13, v5.0GA