-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KILL TIDB or global KILL should cancel DDL #24144
Comments
I chatted with some colleagues on this - some of this might be historical (before global kill). There is also the case that some DDL jobs can not actually be canceled, so having a different statement may be useful since it can retrun an error to the caller etc. |
/severity moderate |
With MySQL if you kill a query/connection that somehow can't be killed it will still be in the processlist with a state of 'Killed' until it is really gone. So TiDB could do something similar. A warning/info message about this would be good indeed. See also: https://dev.mysql.com/doc/refman/8.0/en/general-thread-states.html |
Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
This is forked from #24031
Currently DDL tasks must be killed with
ADMIN CANCEL DDL x
. The MySQL compatible way should be to use theKILL
statement.It should be possible for
KILL TIDB
/KILL
(with global kill) to understand it is a DDL statement and executeADMIN CANCEL DDL
.The text was updated successfully, but these errors were encountered: