Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for unifying log library #24190

Open
4 of 7 tasks
SabaPing opened this issue Apr 21, 2021 · 6 comments
Open
4 of 7 tasks

Tracking issue for unifying log library #24190

SabaPing opened this issue Apr 21, 2021 · 6 comments

Comments

@SabaPing
Copy link
Contributor

SabaPing commented Apr 21, 2021

This issues tracking the progress for "Unify Log Library for Golang Projects"

What problem does this PR solve?

The primary goal is to clean up the logging component. TiDB (and other golang projects) depends on two different third part log components, which are logrus and zap. This creates unnecessary complexity. In addition, there are some other logging flaws in code.

Task Check List

Release note

  • No release note.
@SabaPing
Copy link
Contributor Author

SabaPing commented May 11, 2021

Doc Tasks:

  • Update the logging-related content in the user documentation to clarify the logging configuration and format of each component.

@tisonkun
Copy link
Contributor

tisonkun commented Jun 8, 2021

Hi @SabaPing , what is the next step you would like to go?

If you don't have time to create a PR, you can create subtask issue on BR / PD / TiUP and describe task you'd like to do. And hopefully we can take some of them.

@tisonkun tisonkun changed the title Meta: Unify Log Library for Golang Projects Tracking issue for unifying log library Jul 16, 2021
@tisonkun
Copy link
Contributor

@SabaPing BR is merged into TiDB, you can take a look whether we should change something in the plan.

@SabaPing
Copy link
Contributor Author

SabaPing commented Aug 31, 2021

#23534 caused an issue of unwanted GRPC logs.
And it fixed by pr: #25454.

@SabaPing
Copy link
Contributor Author

SabaPing commented Aug 31, 2021

#23534 caused an issue #25716 that some slow log file configs not working. This made unexpected disk usage.

Fixed by pr: #27625

@SabaPing
Copy link
Contributor Author

There is a pr that enables runtime logger configuration: session: add session var to update global logger max days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants