Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow query file requires a maximum storage time and maximum file limit #25716

Closed
glkappe opened this issue Jun 23, 2021 · 5 comments
Closed

slow query file requires a maximum storage time and maximum file limit #25716

glkappe opened this issue Jun 23, 2021 · 5 comments
Assignees
@SabaPing
Labels
affects-5.2 This bug affects 5.2.x versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@glkappe
Copy link

glkappe commented Jun 23, 2021

slow query file requires a maximum storage time and maximum file limit, like tidb.log
@glkappe glkappe added the type/feature-request Categorizes issue or PR as related to a new feature. label Jun 23, 2021
@glkappe
Copy link
Author

glkappe commented Jun 23, 2021

i need labels

@yiduoyunQ
Copy link

seems just need MaxDays and MaxBackups of SlowQueryFile at https://github.com/pingcap/tidb/blob/v5.1.1/util/logutil/slow_query_logger.go#L25

@qw4990
Copy link
Contributor

qw4990 commented Aug 26, 2021 •
edited
Loading

It should be regarded as a bug ... and seems caused by #23534. Before this PR, MaxDays and MaxBackups can be working for slow-query-logger. PTAL @SabaPing @bb7133

@qw4990 qw4990 added severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug. labels Aug 26, 2021
This was referenced Aug 27, 2021
Merged
Open
@ti-srebot ti-srebot mentioned this issue Nov 18, 2021
Closed
12 tasks
This was referenced Nov 26, 2021
Merged
Merged
@djshow832 djshow832 removed the type/feature-request Categorizes issue or PR as related to a new feature. label Nov 29, 2021
@djshow832
Copy link
Contributor

Closed by #27625

@github-actions
Copy link

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

This was referenced Dec 1, 2021
Closed
Merged
@jyz0309 jyz0309 mentioned this issue Dec 6, 2021
Merged
4 tasks
@yiduoyunQ yiduoyunQ mentioned this issue Jan 14, 2022
Open
ti-chi-bot pushed a commit that referenced this issue Feb 9, 2022
@ti-srebot
[logutil]: Fix MaxDays and MaxBackups not working for slow-query-…
51f6ed9 
…logger (#27625) (#30171)

ref #25716
ti-chi-bot pushed a commit that referenced this issue Feb 17, 2022
@ti-srebot
[logutil]: Fix MaxDays and MaxBackups not working for slow-query-…
88470ec 
…logger (#27625) (#30172)

ref #25716
@jebter jebter added the affects-5.2 This bug affects 5.2.x versions. label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SabaPing SabaPing

Labels
affects-5.2 This bug affects 5.2.x versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jebter @SabaPing @qw4990 @yiduoyunQ @glkappe @djshow832