-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[logutil]: Fix MaxDays
and MaxBackups
not working for slow-query-logger (#27625)
#29921
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@SabaPing please accept the invitation then you can push to the cherry-pick pull requests. Comment with |
/run-check_dev |
/run-check_dev |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ce9ead4
|
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #27625 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/29921
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Fix
MaxDays
andMaxBackups
not working for slow-query-loggerIssue Number: #25716
Problem Summary:
MaxDays
andMaxBackups
not working for slow-query-logger. This may causes unexpected disk usage.What is changed and how it works?
Tests
It seems that code related to log-file-lifecycle-control is not covered by any test case yet ?
Side effects
Documentation
Release note