Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we should rename 'ExplicitStaleness' to 'IsStaleness' #25790

Closed
lcwangchao opened this issue Jun 28, 2021 · 0 comments · Fixed by #25791
Closed

Maybe we should rename 'ExplicitStaleness' to 'IsStaleness' #25790

lcwangchao opened this issue Jun 28, 2021 · 0 comments · Fixed by #25791
Labels
type/question The issue belongs to a question.

Comments

@lcwangchao
Copy link
Collaborator

As the first commit #25206 , ExplicitStaleness is represented for this sql is using stale read explicitly that means it has a 'as of timestamp' clause in it, so it can be false when the txn is a stale read txn.

After this commit #25156 it seems that ExplicitStaleness will be true once it is a in fact stale read. So the name IsStaleness may be betweer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/question The issue belongs to a question.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant